ByteBuddy: Do not use Lookup for non-local mocks #2019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beatbrot
force-pushed
the
bytebuddy-local-mock-detection
branch
from
a9d132d to
c3e4325
Compare
This commit introduces the concept of local mocks. A mock is considered to be local if the target class' classloader can also load all additional interfaces (incl. `ISpockMockObject`). The lookup classloading strategy may only be used if a mock is local. Otherwise we have to defer to other strategies. Fixes spockframework#2017
AndreasTu
requested changes
Oct 12, 2024
spock-specs/src/test/groovy/org/spockframework/mock/runtime/ByteBuddyMockMakerSpec.groovy
Show resolved
Hide resolved
spock-specs/src/test/groovy/org/spockframework/mock/runtime/ByteBuddyMockMakerSpec.groovy
Show resolved
Hide resolved
spock-specs/src/test/groovy/org/spockframework/mock/runtime/ByteBuddyMockMakerSpec.groovy
Show resolved
Hide resolved
spock-core/src/main/java/org/spockframework/mock/runtime/ByteBuddyMockFactory.java
Outdated
Show resolved
Hide resolved
spock-core/src/main/java/org/spockframework/mock/runtime/ByteBuddyMockFactory.java
Show resolved
Hide resolved
spock-core/src/main/java/org/spockframework/mock/runtime/ByteBuddyMockFactory.java
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2019 +/- ##
============================================
+ Coverage 80.44% 81.89% +1.44%
- Complexity 4337 4614 +277
============================================
Files 441 448 +7
Lines 13534 14443 +909
Branches 1707 1826 +119
============================================
+ Hits 10888 11828 +940
+ Misses 2008 1939 -69
- Partials 638 676 +38 ☔ View full report in Codecov by Sentry. |
AndreasTu
approved these changes
Oct 12, 2024
|
@beatbrot Thank you very much for your contribution! |
leonard84
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ByteBuddy: Do not use Lookup for non-local mocks
This PR introduces the concept of local mocks. A mock is considered to be local if the target class' classloader can also load all additional interfaces (incl.
ISpockMockObject).The lookup classloading strategy may only be used if a mock is local.
Otherwise we have to defer to other strategies.
Fixes #2017