Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not timeout tests locally #2077

Merged
merged 2 commits into from
Jan 12, 2025
Merged

Do not timeout tests locally #2077

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3d5e08
Do not timeout tests locally
Vampire Jan 8, 2025
7fdbddf
Merge branch 'master' into vampire/do-not-timeout-tests-locally
leonard84 Jan 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ allprojects {

apply from: script("ide")

boolean isCiServer = System.env["CI"] || System.env["GITHUB_ACTIONS"]
subprojects {
apply plugin: "java-library"
apply plugin: "groovy"
Expand Down Expand Up @@ -195,7 +196,10 @@ subprojects {
}
}
// As a generous general timeout, instead of the 6h of GHA.
timeout = Duration.ofMinutes(15)
// But only on CI or longer needing debug sessions get killed by the timeout.
if (isCiServer) {
timeout = Duration.ofMinutes(15)
Copy link
Member

@leonard84 leonard84 Jan 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably add debug detection to the timeout extension instead.

https://github.com/junit-team/junit5/blob/ee52c64336ad3a079d598bd1c3884bafbc285047/junit-platform-commons/src/main/java/org/junit/platform/commons/util/RuntimeUtils.java#L42

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used debug detections in the past and they only work semi-reliably from my experience.

But I also think it is not the right way, but like I did.

My box was occupied with other stuff and at the same time doing a full check on Spock and the 15 minutes were busted even without debugging. I don't see any reason to have that limit locally, you can at any time abort the build manually easily if you see it hangs.

}
}

tasks.register("allDependencyInsight", DependencyInsightReportTask) {}
Expand Down
Loading