Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix several bugs in cross-multiplication implementation #2123

Merged
merged 2 commits into from
Mar 6, 2025

Conversation

Vampire
Copy link
Member

@Vampire Vampire commented Mar 5, 2025

No description provided.

Copy link
Member Author

Vampire commented Mar 5, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Vampire Vampire requested a review from leonard84 March 5, 2025 03:10
Copy link

codecov bot commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 62.50000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 81.85%. Comparing base (db76b97) to head (4ba2e69).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...rg/spockframework/runtime/DataIteratorFactory.java 62.50% 1 Missing and 11 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2123      +/-   ##
============================================
- Coverage     81.87%   81.85%   -0.02%     
  Complexity     4688     4688              
============================================
  Files           452      452              
  Lines         14656    14673      +17     
  Branches       1846     1859      +13     
============================================
+ Hits          12000    12011      +11     
+ Misses         1976     1973       -3     
- Partials        680      689       +9     
Files with missing lines Coverage Δ
...rg/spockframework/runtime/DataIteratorFactory.java 79.16% <62.50%> (-1.91%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@leonard84 leonard84 enabled auto-merge (squash) March 6, 2025 17:08
@leonard84 leonard84 added this to the 2.4-M6 milestone Mar 6, 2025
@leonard84 leonard84 merged commit a3a77a2 into master Mar 6, 2025
50 of 52 checks passed
@leonard84 leonard84 deleted the vampire/fix-combined branch March 6, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants