Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MOD/#205] 등록화면 다음버튼 과 imePadding을 수정합니다. #206

Merged
merged 5 commits into from
Mar 5, 2025
Merged

[MOD/#205] 등록화면 다음버튼 과 imePadding을 수정합니다. #206

merged 5 commits into from
Mar 5, 2025

Conversation

angryPodo
Copy link
Collaborator

@angryPodo angryPodo commented Feb 25, 2025 •
edited
Loading

Related issue 🛠

Work Description ✏️

  • Nextbutton 패딩 수정
  • ImePadding 추가
  • 검색 결과 도로명 주소가 길어지면 X아이콘 사라지는 버그 수정

Screenshot 📸

fix-padding.mp4

Before

image

After

image

To Reviewers 📢

  • 갤럭시 A8에서 테스트 하다가 발견한 패딩 이슈와 놓친 imePadding 적용했습니다. 그리고 X버튼이 사라져서 버그인줄 알았는데 밀리더라구요.... 요것도 같이 수정했습니다. 하는김에 코드오너도 넣어봤어요~

@angryPodo angryPodo added MOD✅ 코드 수정 및 내부 파일 수정 💙민재💙 💙민재💙 labels Feb 25, 2025
@angryPodo angryPodo self-assigned this Feb 25, 2025
@angryPodo angryPodo linked an issue Feb 25, 2025 that may be closed by this pull request
[MOD] 등록 화면의 다음 버튼 패딩 및 imePadding 수정합니다. #205
Closed
2 tasks
@angryPodo angryPodo requested review from a team and removed request for chattymin, Roel4990 and Hyobeen-Park February 25, 2025 18:24
@angryPodo angryPodo changed the title [MOD/#205] 등록화면 다음 버튼 과 imePadding을 수정합니다. [MOD/#205] 등록화면 다음버튼 과 imePadding을 수정합니다. Feb 25, 2025
@Roel4990
Copy link
Member

Test

Hyobeen-Park
Hyobeen-Park approved these changes Mar 2, 2025
View reviewed changes
Copy link
Collaborator

@Hyobeen-Park Hyobeen-Park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA 굿이네요!! LGTM~~

chattymin
chattymin approved these changes Mar 3, 2025
View reviewed changes
Copy link
Collaborator

@chattymin chattymin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생했어요~ LGTM

Roel4990
Roel4990 approved these changes Mar 3, 2025
View reviewed changes
Copy link
Member

@Roel4990 Roel4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~~~ LGTM~~

@angryPodo angryPodo merged commit 4605378 into develop Mar 5, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chattymin chattymin chattymin approved these changes

@Roel4990 Roel4990 Roel4990 approved these changes

@Hyobeen-Park Hyobeen-Park Hyobeen-Park approved these changes

Assignees

@angryPodo angryPodo

Labels
MOD✅ 코드 수정 및 내부 파일 수정 💙민재💙 💙민재💙
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[MOD] 등록 화면의 다음 버튼 패딩 및 imePadding 수정합니다.
4 participants
@angryPodo @Roel4990 @chattymin @Hyobeen-Park