[FEAT/#197] 서버통신 로그 형식 수정 #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hyobeen-Park
requested review from
chattymin,
Roel4990 and
angryPodo
and removed request for
a team
chattymin
reviewed
Mar 8, 2025
Comment on lines
+3
to
+5
| fun String?.isJsonObject(): Boolean = this?.startsWith("{") == true && this.endsWith("}") | ||
|
|
||
| fun String?.isJsonArray(): Boolean = this?.startsWith("[") == true && this.endsWith("]") |
There was a problem hiding this comment.
이게 어디서 오신줄 알고있으신가요?
제가 33기때 들고와서 솝트에 퍼졌습니다 ㅋㅋㅋ
chattymin
reviewed
Mar 8, 2025
|
|
||
| when { | ||
| jsonMessage.isJsonObject() -> | ||
| Timber.tag("okhttp").d(JSONObject(jsonMessage).toString(4)) |
There was a problem hiding this comment.
p3: 4 라는 값이 의미하는게 아마 TAB일거에요.
이걸 UNIT_TAB이라는 상수로 관리한다면 더욱 의미 전달이 좋을 것 같네요~
There was a problem hiding this comment.
오 TAB 맞습니다!! 이건 상수로 관리하는게 훨씬 좋겠네요ㅎㅎ
angryPodo
approved these changes
Mar 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
as-is
to-be
Uncompleted Tasks 😅
To Reviewers 📢
여기까진 잘 되는거 확인했는데 제가 코드 수정 한번 더 했거든요 그건 서버 열리고 테스트 하고 올려드릴게요ㅎㅎ서버 테스트 완료!! 로그 잘 찍히는거 확인했습니당ㅎㅎ
그리고 등록할 때 이미지도 같이 로그에 찍히는거 너무너무너무너무 불편했는데 이제 dto만 찍히게 stirng 잘라버렸어요ㅎㅎ