This repository has been archived by the owner on Mar 31, 2022. It is now read-only.
#94 properly read maven proxy settings #151
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Properly set all proxy-related system properties (including http.nonProxyHosts) from maven settings, if useProxy is true.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When executing within the maven lifecycle, some of the proxy configuration from settings.xml is read (to set http.proxyHost, http.proxyPort, http.proxyUser and http.proxyPassword System properties), but for some reason http.nonProxyHosts is not properly set. Since version 8.9.1 of "docker-client", the http.proxyHost by default is used if set, hence dockerfile-maven is affected by this behaviour.
This is a known problem, fixed locally in other plugins (see e.g. https://issues.apache.org/jira/browse/CXF-4710).
This fix is inspired by the CFX fix above, to read the settings.xml and populate all relevant system properties for http proxy usage (and restore previous values after execution).