Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle TableRow json specifically #5589

Merged
merged 3 commits into from
Jan 31, 2025
Merged

Handle TableRow json specifically #5589

merged 3 commits into from
Jan 31, 2025

Conversation

RustedBones
Copy link
Contributor

@RustedBones RustedBones commented Jan 30, 2025

Reverts changes in #5416, introduce other strategy for JSON column with TableRow load API

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 61.37%. Comparing base (37f74a2) to head (45ef031).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...la/com/spotify/scio/bigquery/client/TableOps.scala 0.00% 1 Missing ⚠️
.../spotify/scio/bigquery/syntax/TableRowSyntax.scala 66.66% 1 Missing ⚠️
...cala/com/spotify/scio/bigquery/types/package.scala 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5589      +/-   ##
==========================================
+ Coverage   61.26%   61.37%   +0.10%     
==========================================
  Files         314      314              
  Lines       11262    11249      -13     
  Branches      796      783      -13     
==========================================
+ Hits         6900     6904       +4     
+ Misses       4362     4345      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kellen kellen merged commit 9aeba0d into main Jan 31, 2025
12 checks passed
@kellen kellen deleted the tablerow-json branch January 31, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants