Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed id recognize #840

Closed
wants to merge 4 commits into from
Closed

Fixed id recognize #840

wants to merge 4 commits into from

Conversation

albertopasqualetto
Copy link
Contributor

@albertopasqualetto albertopasqualetto commented Jul 29, 2022

Probably api is changed

@stephanebruckert
Copy link
Member

Please provide more details, I don't understand your change and I am not aware of any API changes. Please also try to run lint and unit tests locally as this is currently failing. Check https://github.com/plamere/spotipy/blob/master/CONTRIBUTING.md

@albertopasqualetto
Copy link
Contributor Author

Well, I fixed flake8 errors.
Anyway I get more failures (9) with no changes than with my change (7); the error I get is this:
Immagine 2022-08-02 160323
Because playlist_id is a dictionary in this case, so the actual id needs to be extracted from the dict.

@albertopasqualetto
Copy link
Contributor Author

I see that you are deprecating the 'playlist_add_items` using IDs with #919 , so maybe this PR could be closed, since this error appears in this case.

But if nothing has changed, this was not working since my PR (try testing the playlist_add_items(id)) and this would be until v3 #914 .

This is my code

@stephanebruckert
Copy link
Member

stephanebruckert commented Dec 29, 2022

Ok I'm going to close it.

In your code just make sure you work with track URIs rather than track IDs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants