K8s service instances dupls (WIP) #343
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dupl provisioning, update and unprovisionning request support: - WorkflowServiceInstanceServiceTest completed with test when a provisionning is in progress - Modified service instance repository to be checked and saved for "in progress" status on the servlet thread, as to avoid race condition with the reactor thread - Only skip duplicate request when state repository has an inprogress request, and still fail on async CF-ServiceInstanceNameTaken(60002) for now - Include log to help diagnose ignored duplicate API calls
Compiles, but still some test failures. Need to further diagnose whether this is regressions introduced in production code during cherry pick or test that need update.
This was referenced Mar 25, 2020
|
This osb-cmdb related feature does not seem to be of interest to app-broker use-cases. Closing it as I won't be able to rebase/maintain it if there is interest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP that cherry picks orange-cloudfoundry/osb-cmdb#27 and starts addressing #337, see related design notes at orange-cloudfoundry/osb-cmdb#17 (comment)
Compiles, but there are still some test failures. Need to further diagnose whether this is regression introduced in production code during cherry pick or test that need update. I submitted this PR in case this might help as inspiration, but this is not yet finished.
I'm not sure to be able to allocate much more time on this PR in the short term, so feel free to close this PR if this feels more like pollution.
Dupl provisioning, update and unprovisionning request support: