GH-2806: Pulsar binder defaults properties config #2811
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ensure that the Pulsar binder default properties can be properly expressed via spring.cloud.stream.pulsar.default property prefix. - Add the binder child context bean with the name binderName_binderProducingContext into the parent application context so that individual beans from the binder context can be easily queried. Resolves spring-cloud#2806
onobc
requested changes
Sep 20, 2023
There was a problem hiding this comment.
Nice work @sobychacko ! A couple of minor comments to address.
...cloud-stream/src/main/java/org/springframework/cloud/stream/binder/DefaultBinderFactory.java
Show resolved
Hide resolved
| private final ApplicationContextRunner contextRunner = new ApplicationContextRunner() | ||
| .withUserConfiguration(DefaultPropertiesTestApp.class) | ||
| .withPropertyValues( | ||
| "--spring.pulsar.client.service-url=" + PulsarTestContainerSupport.getPulsarBrokerUrl(), |
There was a problem hiding this comment.
I ❤️ the tests.
One question, is the discrepancy in the property pair prefix intended? (some have --)
There was a problem hiding this comment.
Hmm, it was not intended. Didn't cause an issue. Do you want me to take care of them? or will you adjust on merge?
There was a problem hiding this comment.
If you can take care of them that would be good as I was hoping to just merge from Github for this one.
onobc
approved these changes
Sep 21, 2023
There was a problem hiding this comment.
LGTM! Thanks for the updates @sobychacko . I will merge soon.
|
Closed via 34aae4b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2806