Update Spring Boot to 3.3.6 and bump other dependencies #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corneil
force-pushed
the
corneil/update-boot-to-3-3-6
branch
2 times, most recently
from
12dda25 to
82877a3
Compare
corneil
changed the title
onobc
requested changes
Nov 25, 2024
stream-applications-build/pom.xml
Outdated
| <spring-cloud-function.version>4.1.2</spring-cloud-function.version> | ||
| <spring-cloud-stream-dependencies.version>4.1.2</spring-cloud-stream-dependencies.version> | ||
| <spring-javaformat-checkstyle.version>0.0.43</spring-javaformat-checkstyle.version> | ||
| <spring-boot.version>3.2.12</spring-boot.version> |
There was a problem hiding this comment.
We can't downgrade to a minor version of Boot in a patch release.
There was a problem hiding this comment.
I prepared with the same versions as in spring-functions-catalog so that Artem can see if he can find the error.
There was a problem hiding this comment.
Might be very likely that the problem comes from Debezium itself: they are very prone to ignore compatibility between even between patch versions. I mean we look into some set of Spring versions where it could be just narrowed to Debezium itself .
| <dependency> | ||
| <groupId>org.apache.commons</groupId> | ||
| <artifactId>commons-compress</artifactId> | ||
| <version>${commons-compress.version}</version> | ||
| </dependency> | ||
| <dependency> |
There was a problem hiding this comment.
There was a compile failure in one module.
onobc
reviewed
Nov 26, 2024
applications/sink/xmpp-sink/pom.xml
Outdated
| @@ -45,7 +45,7 @@ | |||
| <dependency> | |||
| <groupId>commons-codec</groupId> | |||
| <artifactId>commons-codec</artifactId> | |||
| <version>1.16.1</version> | |||
| <version>1.17.1</version> | |||
There was a problem hiding this comment.
This is a minor bump, I think we should stick to patch versions.
Updates to Spring Boot 3.3.6 Updates to Spring Framework 6.1.15 Updates to Spring Cloud 2023.0.4 Updates to Spring Cloud Stream 4.1.4 Updates to Spring Cloud Starters 4.1.5 Updates to Spring Cloud Functions 4.1.4 Updates to Spring Functions Catalog 5.0.1 Remove jetbrains NotNull annotation.
corneil
force-pushed
the
corneil/update-boot-to-3-3-6
branch
from
82877a3 to
75538d1
Compare
corneil
changed the title
onobc
reviewed
Nov 29, 2024
| <java-functions.version>5.0.1-SNAPSHOT</java-functions.version> | ||
| <prometheus-rsocket.version>2.0.0-M1</prometheus-rsocket.version> | ||
| <java-functions.version>5.0.1</java-functions.version> | ||
| <prometheus-rsocket.version>2.0.0-M2</prometheus-rsocket.version> |
There was a problem hiding this comment.
I just realized that I updated this from 1.5.2 to 2.0.0-M1 in 726d7cd.
One of two things needs to happen:
- we put this version back to
1.5.xand release w/ that (5.0.xreleased w/1.5.2). - OR we get a GA for
2.0.0as we can't release w/ a milestone.
| @@ -74,16 +72,16 @@ | |||
|
|
|||
| <dependencyManagement> | |||
| <dependencies> | |||
| <dependency> | |||
| @@ -135,13 +133,6 @@ | |||
| <artifactId>ivy</artifactId> | |||
| <version>${apache-ivy.version}</version> | |||
| </dependency> | |||
| <dependency> | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates Spring Functions Catalog to 5.0.1
Updates Spring Boot to 3.3.6
Updates RabbitMQ Http Client to 5.2.0
Updates NoHttp Checkstyle to 0.0.11
Updates Spring Java Format Checkstyle to 0.0.43
Updates Spring Framework to 6.1.15
Updates Spring Cloud Release Train to 2023.0.4
Updates Spring Cloud Starters to 4.1.5
Updates Spring Cloud Function to 4.1.4
Updates Spring Cloud Stream to 4.1.4
Updates Groovy to 4.0.24
Removes spring-integration-aws.version property now manage in Spring Functions Catalog Removes json-path.version as it is managed in Spring Boot dependencies.
Removes Jetbrains
@NotNullfrom a Test class.See #584