Introduce factory method for ProjectGenerator creation #1582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed transient modifier.
|
@zambrovski Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
spring-projects-issues
added
the
status: waiting-for-triage
|
@zambrovski Thank you for signing the Contributor License Agreement! |
mhalbritter
added
type: enhancement
and removed
status: waiting-for-triage
mhalbritter
pushed a commit
that referenced
this pull request
Nov 11, 2024
Also remove an unneeded transient modifier. See gh-1582
|
Thank you very much and congratulations on your first contribution 🎉! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behaviour
Since the
ProjectGeneratoroffersprotectedmethods, a use case of sub-classing it is supported. In the same time, theProjectGeneratorInvokercreates the instance of it just in place where it is used.Expected behavior
I can easily subclass the
ProjectGeneratorand replace its invocation.Proposed solution
This PR extracts the creation of the
ProjectGeneratorto a factory method. In doing so, it allows to replace theProjectGeneratorInvokerwith own implementation, overriding the creation of theProjectGeneratorwith own sub-classed version and use that instead of the original one.In addition, the transient modifier of the temp files seems to be unneeded, since the
ProjectGeneratorInvokershould not be serialized/deserialized,transientis not used in any other place in the project and is a little surprising at that location.