Skip to content

Commit

Permalink
remove comments per feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
alexanderankin committed Dec 18, 2024
1 parent 5763aef commit 6653687
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@ protected void customizeExtensions(GradleExtensionContainer extensions) {
(grpc) -> grpc.attribute("artifact", quote("io.grpc:protoc-gen-grpc-java"))));
protobuf.nested("generateProtoTasks", (generateProtoTasks) -> generateProtoTasks.nested("all()*.plugins",
(plugins) -> plugins.nested("grpc", (grpc) -> {
grpc.invoke("option", quote("jakarta_omit") + " // legacy (v1.63) param");
grpc.invoke("option", quote("@generated=omit") + " // param name starting v1.64");
grpc.invoke("option", quote("jakarta_omit"));
grpc.invoke("option", quote("@generated=omit"));
})));
});
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ protected void customizeExtensions(GradleExtensionContainer extensions) {
(grpc) -> grpc.attribute("artifact", quote("io.grpc:protoc-gen-grpc-java"))));
protobuf.nested("generateProtoTasks", (generateProtoTasks) -> generateProtoTasks.nested("all().forEach",
(forEach) -> forEach.nested("it.plugins", (plugins) -> plugins.nested("id(\"grpc\")", (grpc) -> {
grpc.invoke("option", quote("jakarta_omit") + " /* legacy (v1.63) param */");
grpc.invoke("option", quote("@generated=omit") + " /* param name starting v1.64 */");
grpc.invoke("option", quote("jakarta_omit"));
grpc.invoke("option", quote("@generated=omit"));
}))));
});
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,8 @@ void shouldAddGrpcPluginAndConfigurationForGradleGroovy() {
generateProtoTasks {
all()*.plugins {
grpc {
option 'jakarta_omit' // legacy (v1.63) param
option '@generated=omit' // param name starting v1.64
option 'jakarta_omit'
option '@generated=omit'
}
}
}
Expand Down Expand Up @@ -105,8 +105,8 @@ void shouldAddGrpcPluginAndConfigurationForGradleKotlin() {
all().forEach {
it.plugins {
id("grpc") {
option("jakarta_omit" /* legacy (v1.63) param */)
option("@generated=omit" /* param name starting v1.64 */)
option("jakarta_omit")
option("@generated=omit")
}
}
}
Expand Down

0 comments on commit 6653687

Please sign in to comment.