Fix gRPC Maven configuration

Adding multiple pluginParameter tags doesn't work, the options need to be separated by comma. Closes gh-1686
spring-io · Dec 20, 2024 · 7f436b3 · 7f436b3
1 parent 1f305a0
commit 7f436b3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/...n/java/io/spring/start/site/extension/dependency/springgrpc/GrpcMavenBuildCustomizer.java b/...n/java/io/spring/start/site/extension/dependency/springgrpc/GrpcMavenBuildCustomizer.java
@@ -79,10 +79,8 @@ private void addProtobufPlugin(MavenPluginContainer plugins, VersionProperty pro
 			});
 			plugin.execution("compile", (execution) -> {
 				execution.goal("compile").goal("compile-custom");
-				execution.configuration((configuration) -> {
-					configuration.add("pluginParameter", "jakarta_omit");
-					configuration.add("pluginParameter", "@generated=omit");
-				});
+				execution.configuration(
+						(configuration) -> configuration.add("pluginParameter", "jakarta_omit,@generated=omit"));
 			});
 		});
 	}

diff --git a/...t/site/extension/dependency/springgrpc/SpringGrpcProjectGenerationConfigurationTests.java b/...t/site/extension/dependency/springgrpc/SpringGrpcProjectGenerationConfigurationTests.java
@@ -160,8 +160,7 @@ void shouldAddProtobufPluginForMaven() {
 											<goal>compile-custom</goal>
 										</goals>
 										<configuration>
-											<pluginParameter>jakarta_omit</pluginParameter>
-											<pluginParameter>@generated=omit</pluginParameter>
+											<pluginParameter>jakarta_omit,@generated=omit</pluginParameter>
 										</configuration>
 									</execution>
 								</executions>