Add Netflix DGS Codegen plugin support #1348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bclozel
force-pushed
the
dgs-codegen
branch
2 times, most recently
from
96f529b to
8162ce8
Compare
snicoll
reviewed
Nov 15, 2023
| compatibilityRange: "3.0.0-M1" | ||
| groupId: com.netflix.graphql.dgs.codegen | ||
| artifactId: graphql-dgs-codegen-gradle | ||
| mappings: |
There was a problem hiding this comment.
Wondering if we need a mapping here considering that the artifact is just a trigger for the build system setup.
There was a problem hiding this comment.
Right now the only added benefit is that if we upgrade the plugin version and it's not fully published on Maven Central, our verification tests will catch it. I'd be tempted to leave that in for this reason.
...ava/io/spring/start/site/extension/dependency/dgs/DgsCodegenHelpDocumentCustomizerTests.java
Outdated
Show resolved
Hide resolved
...pring/start/site/extension/dependency/dgs/DgsCodegenProjectGenerationConfigurationTests.java
Outdated
Show resolved
Hide resolved
...pring/start/site/extension/dependency/dgs/DgsCodegenProjectGenerationConfigurationTests.java
Outdated
Show resolved
Hide resolved
.../main/java/io/spring/start/site/extension/dependency/dgs/DgsCodegenMavenBuildCustomizer.java
Outdated
Show resolved
Hide resolved
bclozel
force-pushed
the
dgs-codegen
branch
2 times, most recently
from
6c42215 to
ad96ce0
Compare
|
This PR is still in draft mode, we're discussing some details here and maybe we should link to Spring for GraphQL's docs once spring-projects/spring-graphql#847 is resolved. |
snicoll
added
status: waiting-for-triage
This commit adds a new dependency to start.spring.io, the "Netflix Data Graph Service Codegen". This will not add a dependency to generated project, but rather configure a Maven or a Gradle plugin in the build. This Codegen plugin parses GraphQL schema files describing remote GraphQL APIs and generates Java classes to easily create queries and deserialize GraphQL responses.
bclozel
added
type: enhancement
and removed
status: waiting-for-triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new dependency to start.spring.io, the "Netflix Data
Graph Service Codegen". This will not add a dependency to generated
project, but rather configure a Maven or a Gradle plugin in the build.
This Codegen plugin parses GraphQL schema files describing remote
GraphQL APIs and generates Java classes to easily create queries and
deserialize GraphQL responses.