Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Pulsar container to 'latest' tag #1376

Closed
wants to merge 2 commits into from

Conversation

onobc
Copy link
Contributor

@onobc onobc commented Dec 14, 2023

This commit updates the Pulsar Docker container version from 3.1.0 to 3.1.1 for both the Docker Compose file and the Testcontainers generated container definition.

For reference, Spring Boot uses 3.1.1 for its recommended version.

@snicoll
Copy link
Contributor

snicoll commented Dec 14, 2023

If there is a relationship between the container version and the library version, we should not hardcode the version here but rather read the version from the BOM.

Is there any reason we're not doing that?

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 14, 2023
@onobc
Copy link
Contributor Author

onobc commented Dec 14, 2023

If there is a relationship between the container version and the library version, we should not hardcode the version here but rather read the version from the BOM.

Is there any reason we're not doing that?

Good point. There is container created that corresponds to the version but I believe it is not released at the same time as the library. I have reached out to the Pulsar team for more details on this process and what guarantees there are (if any). Would it be worth adding a managed version in the BOM for the pulsar container? What are the other supported techs doing in this area (or do they all have a 1:1 relationship between library and container versions)?

@onobc
Copy link
Contributor Author

onobc commented Dec 14, 2023

@snicoll I got feedback from the Pulsar team, w/ the latest release process, the containers are released with the library, but they show up on Docker hub sometime after the library is available on Maven central. I think for our use we can rely on this mapping since by the time we pull the updated library version, the container is likely available (or will be shortly). If you agree, I will remove the hardcoding in this PR and instead get the version from the SB recommended version.

@snicoll
Copy link
Contributor

snicoll commented Dec 15, 2023

Sounds good, thanks!

@onobc onobc changed the title Update Pulsar container to version specified in Spring Boot (3.1.1) Update Pulsar container to use 'latest' tag Dec 15, 2023
@onobc
Copy link
Contributor Author

onobc commented Dec 15, 2023

@snicoll digging a bit further, the Pulsar containers are now properly using 'latest' tag to match the actual "latest" version. Reduced the complexity here accordingly.

@snicoll snicoll added type: enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 18, 2023
@snicoll snicoll self-assigned this Dec 18, 2023
@snicoll snicoll changed the title Update Pulsar container to use 'latest' tag Move Pulsar container to 'latest' tag Dec 18, 2023
snicoll pushed a commit that referenced this pull request Dec 18, 2023
@snicoll snicoll closed this in 2ef73ed Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants