Use local storage to remember user choices #1459
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
|
Hey @4121nnn, i pushed a commit to this PR which polishes a bit. What do you think of the changes? I moved all the localStorage storing into the event listeners instead of fiddling with the update function, and refactored code in some methods for better readability. I also removed the storage of the selected Boot version. I don't think that this brings much value, as the versions change every month. |
mhalbritter
changed the title
mhalbritter
added
type: enhancement
status: waiting-for-feedback
|
Thank you for improvements @mhalbritter . Your changes looks much better than my code |
spring-projects-issues
added
status: feedback-provided
|
Closing in favour of #1462 |
mhalbritter
added
status: superseded
and removed
type: enhancement
status: feedback-provided
|
No problem @mhalbritter, actually it is my first pull request ever. I will keep improving my skills. But thanks anyway for letting me participate in this project , I really appreciate that |
|
Keep 'em coming! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caching implemented to these fields:
Project, Language, Spring boot, Packaging and Java version.