Update McpToolUtils.java #4192
Closed
Update McpToolUtils.java #4192
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix McpToolUtils.prefixedToolName formatted in order to support Chinese characters in toolName Signed-off-by: shishuiwuhen2009 <[email protected]>
fix McpToolUtils.prefixedToolName formatted in order to support Chinese characters in toolName. Signed-off-by: shishuiwuhen2009 <[email protected]>
spring-builds
pushed a commit
that referenced
this pull request
Aug 21, 2025
Replace hard-coded Unicode range with comprehensive Unicode property approach
to fix incomplete Han character coverage in MCP tool name formatting.
Changes:
- Replace \u4e00-\u9fa5 range with union of Unicode Script and Block properties
- Use \p{IsHan} + \p{InCJK_Unified_Ideographs} + \p{InCJK_Compatibility_Ideographs}
- Fix boundary case where \u9fff was incorrectly excluded by script-only approach
- Add comprehensive test coverage for all Han character blocks and edge cases
Technical details:
- Addresses Unicode Script vs Block classification differences across JDK versions
- \u9fff (鿿) is in CJK Unified Ideographs block but not Han script in some JDKs
- Union approach ensures complete coverage while maintaining exclusion of other scripts
- Future-proof solution that automatically includes new Han characters in Unicode updates
Test coverage added:
- CJK Unified Ideographs boundary cases (\u4e00, \u9fff)
- CJK Extension A characters (\u3400)
- CJK Compatibility Ideographs (\uf900)
- Mixed character block scenarios
- Proper exclusion verification for non-Han scripts (Hiragana, Emoji, etc.)
Fixes incomplete Chinese character support while maintaining backward compatibility
and minimal risk profile of the original change.
Signed-off-by: shishuiwuhen2009
Signed-off-by: Mark Pollack <[email protected]>
Fixes #4192
(cherry picked from commit 35486e9)
|
Thanks!!! had some help from ai! let me know what you think of the final changes @shishuiwuhen2009 . it is also backported. |
|
Thank you so much for your detailed modification suggestions! This Unicode property-based approach for Chinese character support is much more standardized and comprehensive than my original hard-coded range method. I’ve learned a lot about robust Unicode handling—especially the nuances of Script vs. Block classification across JDK versions and how to ensure full Han character coverage. It’s really helpful for improving the quality of my code. Great work on pointing out these key details! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix McpToolUtils.prefixedToolName formatted in order to support Chinese characters in toolName