Extract constant and unify messages in Log4JCoreLoggerContextCondition #45967
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
- Moved the repeated string "org.apache.logging.log4j.core.LoggerContext" to a private static final constant - Used the constant in Class.forName() and ConditionOutcome messages - Unified inconsistent messages: changed "Logger context" to "LoggerContext" for consistency with the class name Signed-off-by: wonyongg <[email protected]>
wonyongg
force-pushed
the
loggercontext-constant
branch
from
cfcdac9 to
ddb9979
Compare
mhalbritter
added
type: task
mhalbritter
changed the title
snicoll
pushed a commit
that referenced
this pull request
Jun 17, 2025
See gh-45967 Signed-off-by: wonyongg <[email protected]>
snicoll
added a commit
that referenced
this pull request
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the readability and consistency of
Log4JCoreLoggerContextConditionby:"org.apache.logging.log4j.core.LoggerContext"into a constant namedLOGGER_CONTEXT_CLASS_NAMEClass.forName(...)) and theConditionOutcome.match()/noMatch()messagesThese small improvements help reduce duplication and improve maintainability without changing any functional logic.