Fix #{#entityName} to return table name for native queries #3982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…name Fixes spring-projects#3979 Native queries with SELECT * and #{#entityName} were failing because #{#entityName} was returning the entity name instead of the table name for native queries. This change: - Adds getTableName() method to JpaEntityMetadata interface with default implementation - Makes #{#entityName} return table name for native queries and entity name for JPQL queries - Removes instanceof checks for cleaner, type-safe code Added test to verify the fix works correctly. Signed-off-by: academey <[email protected]>
academey
force-pushed
the
fix/3979-native-query-spel-regression
branch
from
b81c04a to
c811561
Compare
spring-projects-issues
added
the
status: waiting-for-triage
|
This is not a fix but rather introduction of new functionality. That isn't going to make the cut here as Hibernate uses a |
mp911de
added
status: declined
|
Thanks for looking into this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3979
#{#entityName}was returning entity name instead of table name for native queries, causing failures withSELECT *.Changes:
getTableName()toJpaEntityMetadatainterface