GH-2941: Minor changes in MessageListenerAdapter

Fixes: #2941 minor adjustment at `MessagingMessageListenerAdapter` (#2941)
spring-projects · Dec 15, 2023 · ac4aa7c · ac4aa7c
1 parent a57c319
commit ac4aa7c
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 15 deletions.
diff --git a/...java/org/springframework/kafka/listener/adapter/BatchMessagingMessageListenerAdapter.java b/...java/org/springframework/kafka/listener/adapter/BatchMessagingMessageListenerAdapter.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2016-2021 the original author or authors.
+ * Copyright 2016-2023 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -63,7 +63,7 @@ public class BatchMessagingMessageListenerAdapter<K, V> extends MessagingMessage
 
 	private BatchMessageConverter batchMessageConverter = new BatchMessagingMessageConverter();
 
-	private KafkaListenerErrorHandler errorHandler;
+	private final KafkaListenerErrorHandler errorHandler;
 
 	private BatchToRecordAdapter<K, V> batchToRecordAdapter;
 

diff --git a/...main/java/org/springframework/kafka/listener/adapter/MessagingMessageListenerAdapter.java b/...main/java/org/springframework/kafka/listener/adapter/MessagingMessageListenerAdapter.java
@@ -529,26 +529,20 @@ private Message<?> checkHeaders(Message<?> reply, @Nullable String topic, @Nulla
 
 	@SuppressWarnings("unchecked")
 	private void sendSingleResult(Object result, String topic, @Nullable Object source) {
-		byte[] correlationId = null;
-		boolean sourceIsMessage = source instanceof Message;
-		if (sourceIsMessage
-				&& getCorrelation((Message<?>) source) != null) {
-			correlationId = getCorrelation((Message<?>) source);
-		}
-		if (sourceIsMessage) {
-			sendReplyForMessageSource(result, topic, source, correlationId);
+		if (source instanceof Message<?> message) {
+			sendReplyForMessageSource(result, topic, message, getCorrelation(message));
 		}
 		else {
 			this.replyTemplate.send(topic, result);
 		}
 	}
 
 	@SuppressWarnings("unchecked")
-	private void sendReplyForMessageSource(Object result, String topic, Object source, @Nullable byte[] correlationId) {
+	private void sendReplyForMessageSource(Object result, String topic, Message<?> source, @Nullable byte[] correlationId) {
 		MessageBuilder<Object> builder = MessageBuilder.withPayload(result)
 				.setHeader(KafkaHeaders.TOPIC, topic);
 		if (this.replyHeadersConfigurer != null) {
-			Map<String, Object> headersToCopy = ((Message<?>) source).getHeaders().entrySet().stream()
+			Map<String, Object> headersToCopy = source.getHeaders().entrySet().stream()
 					.filter(e -> {
 						String key = e.getKey();
 						return !key.equals(MessageHeaders.ID) && !key.equals(MessageHeaders.TIMESTAMP)
@@ -568,7 +562,7 @@ private void sendReplyForMessageSource(Object result, String topic, Object sourc
 		if (correlationId != null) {
 			builder.setHeader(this.correlationHeaderName, correlationId);
 		}
-		setPartition(builder, ((Message<?>) source));
+		setPartition(builder, source);
 		this.replyTemplate.send(builder.build());
 	}
 

diff --git a/...ava/org/springframework/kafka/listener/adapter/RecordMessagingMessageListenerAdapter.java b/...ava/org/springframework/kafka/listener/adapter/RecordMessagingMessageListenerAdapter.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2021 the original author or authors.
+ * Copyright 2002-2023 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -53,7 +53,7 @@
 public class RecordMessagingMessageListenerAdapter<K, V> extends MessagingMessageListenerAdapter<K, V>
 		implements AcknowledgingConsumerAwareMessageListener<K, V> {
 
-	private KafkaListenerErrorHandler errorHandler;
+	private final KafkaListenerErrorHandler errorHandler;
 
 	public RecordMessagingMessageListenerAdapter(Object bean, Method method) {
 		this(bean, method, null);