Fix race condition in the ObservationTests

The listener may also report its span before we assert against current `tracer.getSpans()`
spring-projects · Nov 13, 2024 · be53360 · be53360
1 parent 0318c1d
commit be53360
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/...ng-kafka/src/test/java/org/springframework/kafka/support/micrometer/ObservationTests.java b/...ng-kafka/src/test/java/org/springframework/kafka/support/micrometer/ObservationTests.java
@@ -153,6 +153,9 @@ public void configure(Map<String, ?> configs) {
 			}
 		});
 
+		MessageListenerContainer listenerContainer1 = rler.getListenerContainer("obs1");
+		listenerContainer1.stop();
+
 		template.send(OBSERVATION_TEST_1, "test")
 				.thenAccept((sendResult) -> spanFromCallback.set(tracer.currentSpan()))
 				.get(10, TimeUnit.SECONDS);
@@ -166,7 +169,7 @@ public void configure(Map<String, ?> configs) {
 				"key", "value"));
 
 		assertThat(spanFromCallback.get()).isNotNull();
-		MessageListenerContainer listenerContainer1 = rler.getListenerContainer("obs1");
+		listenerContainer1.start();
 		MessageListenerContainer listenerContainer2 = rler.getListenerContainer("obs2");
 		assertThat(listenerContainer1).isNotNull();
 		assertThat(listenerContainer2).isNotNull();