New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unnecessary property setting statement in EmbeddedKafkaKraftBroker #2893

Merged

artembilan merged 1 commit into spring-projects:main from NathanQingyangXu:fix-EmbeddedKafkaBroker-property-issue

Nov 13, 2023

Contributor

NathanQingyangXu commented Nov 11, 2023

if (this.brokerListProperty != null) {
    System.setProperty(this.brokerListProperty, getBrokersAsString());
}
System.setProperty(SPRING_EMBEDDED_KAFKA_BROKERS, getBrokersAsString());
System.setProperty(this.brokerListProperty, getBrokersAsString());

The last statement seems unnecessary and could lead to exception thrown if this.brokerListProperty is null


          remove unnecessary property setting statement in EmbeddedKafkaKraftBr…

…oker

Member

artembilan commented Nov 13, 2023

This is covered in the #2872.
But yeah... it is not clear when (and if) that one is going to be merged...

artembilan added this to the 3.1.0 milestone

artembilan added the type: enhancement label

artembilan merged commit f768874 into spring-projects:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: enhancement