Gh-2924 Fix send null payload with KafkaTemplate#send(Message), and … #2925
Conversation
|
@pswrdf Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@pswrdf Thank you for signing the Contributor License Agreement! |
|
@pswrdf Thanks for the PR! Can you add a unit test to verify the changes? Or point to an existing test where this code is exercised. |
There was a problem hiding this comment.
Hi @pswrdf !
Thank you for contribution.
Please, make yourself familiar with commit message rules we try to follow: https://cbea.ms/git-commit/.
I don't say that you need to change anything right now if you don't want, but just for the future to avoid comments from me like this 😉
This fix is supposed to be back-ported to 3.0.x.
When you merge this, please, consider to include Fixes: gh-2924 like into commit message.
This way Backport Bot GHA workflow will create a respective back-port issue for for current 3.0.x milestone. However don't merge yet, please, I'm working in that branch right now to migrate it into GHA.
There was a problem hiding this comment.
So, now CI/CD infra is set up for 3.0.x.
Therefore we are good to cherry-pick after merging this.
- Add some unit test, please. See
BatchListenerConversionTestswhere we use one of thoseJsonMessageConverterimpls. - Add your name to the
@authorlist of all the affected classes. - Add also
Fixes: gh-2924into next commit message as I asked before. - Add
**Cherry-pick to3.0.x**into the next commit message.
Thanks
…d(Message) and JsonMessageConverter Fixes: spring-projects#2924 Add posibility to send KafkaNull message payload with JsonMessageConverter.
…d(Message) and JsonMessageConverter Fixes: spring-projects#2924 Add posibility to send KafkaNull message payload with JsonMessageConverter. **Cherry-pick to 3.0.x**
...ng-kafka/src/main/java/org/springframework/kafka/support/converter/JsonMessageConverter.java
Show resolved
Hide resolved
|
I think it's done. Would I squash commits? It needs to change email also. |
|
No, you shouldn't squash the commits once a PR is issued. We will squash it upon merging. Thanks! |
|
... and cherry-picked to |
…JsonMessageConverter
fixes: #2924