Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-2927 Resolve subclasses of EmbeddedKafkaBroker in tests #2931

Merged
merged 4 commits into from
Dec 15, 2023
Merged

GH-2927 Resolve subclasses of EmbeddedKafkaBroker in tests #2931

merged 4 commits into from
Dec 15, 2023

Conversation

Sh1ftry
Copy link
Contributor

@Sh1ftry Sh1ftry commented Dec 11, 2023

Fixes #2927

artembilan
artembilan requested changes Dec 11, 2023
View reviewed changes
Copy link
Member

@artembilan artembilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chances to supplement the fix with the test?
Even if it is just a modification to the existing EmbeddedKafkaConditionTests where we would change that EmbeddedKafkaBroker broker method argument to the EmbeddedKafkaZKBroker type.

@artembilan artembilan merged commit 4b7e53e into spring-projects:main Dec 15, 2023
2 checks passed
@artembilan
Copy link
Member

@Sh1ftry ,

thank you for contribution; looking forward for more!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artembilan artembilan artembilan requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No parameter resolver for EmbeddedKafkaZKBroker
2 participants
@Sh1ftry @artembilan