GH-2943: Fix KT.clusterId() for concurrency
#2944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: spring-projects#2943 The `if (this.kafkaAdmin != null && this.clusterId == null) {` condition might be always true for concurrent threads (especially virtual). Therefore, all of those threads are calling `this.kafkaAdmin.clusterId()` making unnecessary network chats to Kafka broker * Surround `this.kafkaAdmin.clusterId()` call with `Lock` **Cherry-pick to `3.0.x`**
sobychacko
approved these changes
Dec 17, 2023
sobychacko
pushed a commit
that referenced
this pull request
Dec 17, 2023
Fixes: #2943 The `if (this.kafkaAdmin != null && this.clusterId == null) {` condition might be always true for concurrent threads (especially virtual). Therefore, all of those threads are calling `this.kafkaAdmin.clusterId()` making unnecessary network chats to Kafka broker * Surround `this.kafkaAdmin.clusterId()` call with `Lock` **Cherry-pick to `3.0.x`**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2943
The
if (this.kafkaAdmin != null && this.clusterId == null) {condition might be always true for concurrent threads (especially virtual). Therefore, all of those threads are callingthis.kafkaAdmin.clusterId()making unnecessary network chats to Kafka brokerthis.kafkaAdmin.clusterId()call withLockCherry-pick to
3.0.x