-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-3001: default clientIds with application name #3048
Conversation
@notizklotz I am Starting to review the PR. There are some build failures due to checkstyle issues. See here. |
@sobychacko I fixed the checkstyle errors and added some docs to the "What’s new?" section |
@notizklotz Thanks. The problem with adding this in the |
Fixes: #spring-projectsGH-3001 Use Spring Boot's `spring.application.name` property as part of the default clientIds for Consumers, Producers and AdminClients. Helps with identifying problematic clients at server side. * Only use as a fallback if clientId wasn't specified explicitly * Do not use for Consumers with a specified groupId because KafkaConsumer will use the groupId as clientId which already is an identifiable default
@sobychacko Added section to reference docs, added author tag, checked copyright years, squashed commits and rebased to upstream main |
Thanks @notizklotz for the updates. One last comment - What do you think about extracting |
@sobychacko I considered that but decided against it, because I couldn't find an existing class where I think it would be a good fit. I didn't want to introduce a new class like "Constants" just for this literal. I also saw that the "client-id" literal is also copy/pasted across various classes and I thought to stick with the existing style. |
Fair enough. We can always refactor that later if need be. |
Fixes: #GH-3001
Use Spring Boot's
spring.application.name
property as part of the default clientIds for Consumers, Producers and AdminClients. Helps with identifying problematic clients at server side.