Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-2287: Align RecordInterceptor and BatchInterceptor lifecycle. #3053

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

Wzy19930507
Copy link
Contributor

Resolves #2287

Resolves spring-projects#2287

* Align lifecycle for earlyRecordInterceptor(intercept + failure/success + afterRecord) and earlyBatchInterceptor(intercept + failure/success).
* Fix unit test KafkaMessageListenerContainerTests, see spring-projects#2722 and spring-projects#2287.
@Wzy19930507 Wzy19930507 changed the title Align RecordInterceptor and BatchInterceptor lifecycle. GH-2287: Align RecordInterceptor and BatchInterceptor lifecycle. Feb 21, 2024
@sobychacko sobychacko merged commit 0b321cf into spring-projects:main Feb 21, 2024
3 checks passed
@Wzy19930507 Wzy19930507 deleted the GH-2287 branch February 22, 2024 05:00
sobychacko pushed a commit that referenced this pull request Mar 1, 2024
Fixes: #2287

Resolves #2287

* Align lifecycle for earlyRecordInterceptor(intercept + failure/success + afterRecord) and earlyBatchInterceptor(intercept + failure/success).
* Fix unit test KafkaMessageListenerContainerTests, see #2722 and #2287.

(cherry picked from commit 0b321cf)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RecordInterceptor lifecycle is wrong if record filtered
2 participants