GH-3166: BatchInterceptor issues with retries #3167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: spring-projects#3166 * When retries are enabled, batch interceptor is not invoking the intercept methods for failures on retries and the possible eventual success method call. Addressing this issue.
sobychacko
commented
Mar 28, 2024
...fka/src/test/java/org/springframework/kafka/listener/KafkaMessageListenerContainerTests.java
Show resolved
Hide resolved
artembilan
requested changes
Mar 28, 2024
| given(consumer.poll(any(Duration.class))).willAnswer(i -> { | ||
| Thread.sleep(50); | ||
| if (invocation.get() == 0) { | ||
| invocation.getAndIncrement(); |
There was a problem hiding this comment.
This definitely can be a part of that if: no need to call get and then getAndIncrement. The last one would contribute exactly same value for that if.
Also I'm not sure that Thread.sleep(50). Even if it is small enough, we still need to be sure that we need such a delay.
Why to make test slower for nothing?
|
@artembilan I added the backport labels to the original issue. I will tackle the test comments soon. |
artembilan
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3166