Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ackDiscarded. #3212

Merged
merged 5 commits into from
Apr 23, 2024
Merged

Fix ackDiscarded. #3212

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ce1961b
fix ackDiscarded.
chickenchickenlove Apr 23, 2024
22483e8
apply review
chickenchickenlove Apr 23, 2024
99f5430
apply review.
chickenchickenlove Apr 23, 2024
e6612cf
Add author
chickenchickenlove Apr 23, 2024
974231d
apply review
chickenchickenlove Apr 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...src/main/java/org/springframework/kafka/config/AbstractKafkaListenerContainerFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright 2014-2023 the original author or authors.
* Copyright 2014-2024 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down
1 change: 1 addition & 0 deletions ...g-kafka/src/main/java/org/springframework/kafka/config/AbstractKafkaListenerEndpoint.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,6 +326,7 @@ public void setReplyTemplate(KafkaTemplate<?, ?> replyTemplate) {
@SuppressWarnings("unchecked")
public void setRecordFilterStrategy(RecordFilterStrategy<? super K, ? super V> recordFilterStrategy) {
this.recordFilterStrategy = (RecordFilterStrategy<K, V>) recordFilterStrategy;
setAckDiscarded(true);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking deeper, I don't think this fix is correct.
See more further:

	/**
	 * Create an instance with the supplied strategy and delegate listener.
	 * @param delegate the delegate.
	 * @param recordFilterStrategy the filter.
	 * @param ackDiscarded true to ack (commit offset for) discarded messages when the
	 * listener is configured for manual acks.
	 */
	public FilteringMessageListenerAdapter(MessageListener<K, V> delegate,
			RecordFilterStrategy<K, V> recordFilterStrategy, boolean ackDiscarded) {

Therefore it is up to end-user to decide if ackDiscarded or not.

So, what the problem we are trying to fix here, please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see 👍

How about fix the java docs of setAckDiscarded 's Set to true if the {@link #setRecordFilterStrategy(RecordFilterStrategy)} is in use. ?

For example, Set to true if the {@link #setRecordFilterStrategy(RecordFilterStrategy)} is in use and ack discarded messages?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about:

Set to true if the {@link #setRecordFilterStrategy(RecordFilterStrategy)} should ack discarded messages.

?

Copy link
Contributor Author

@chickenchickenlove chickenchickenlove Apr 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's more suitable. (sorry i'm not good at english well🥲 ).
may i fix it? or it's okay to close this PR if you think that it is not needed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please.
Just part of this PR is OK.
Thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot 🙇‍♂️
I updated It!

}

protected boolean isAckDiscarded() {
Expand Down