Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT : Add checkstyle: max line length 119. #3220

Conversation

chickenchickenlove
Copy link
Contributor

Background

  • Recently, i have learned that spring-kafka project has a line length convention. It would be better to include that rules to checkStyle. (The code line length ! > 120 symbols.)

To Reviewer

After adding new rule to checkStyle, checkStyle throw a lot of style error. If you guys want to introduce this rule to checkStyle, i'm willing to fix all of style error.
However, you guys don't want it, i will close this PR.

image

Copy link
Member

@artembilan artembilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the effort , but we cannot enforce such a rule. Sometimes it is just impossible to break at 120. It is just recommendation to make code more readable and easy to review. Remember this is an Open Source, so perfectly looking code is our goal.

My vote is to reject this change.

Thanks for understanding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants