DRAFT : Add checkstyle: max line length 119. #3220
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
spring-kafka
project has a line length convention. It would be better to include that rules tocheckStyle
. (The code line length ! > 120 symbols.)To Reviewer
After adding new rule to
checkStyle
,checkStyle
throw a lot ofstyle error
. If you guys want to introduce this rule tocheckStyle
, i'm willing to fix all ofstyle error
.However, you guys don't want it, i will close this PR.