GH-3528: Improving Observability in Asynchronous Processing #3558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssing Fixes: spring-projects#3528 spring-projects#3528 - Improve spring-kafka observability for failures in async consumer tasks when listener methods return CompletableFuture<?> or Mono<?> and throw errors during async execution - Refactoring code in KafkaMessageListenerContainer and MessagingMessageListenerAdapter around observability - Adding tests to verify - Add @nullable annotations to relevant methods for better null safety
sobychacko
changed the title
artembilan
requested changes
Oct 15, 2024
| catch (RuntimeException e) { | ||
| failureTimer(sample, cRecord); | ||
| recordInterceptAfter(cRecord, e); | ||
| if (!(this.listener instanceof MessagingMessageListenerAdapter<?, ?>)) { |
There was a problem hiding this comment.
I wonder if for consistency this condition has also to be against RecordMessagingMessageListenerAdapter...
| } | ||
| } | ||
| finally { | ||
| if (!(this.listener instanceof MessagingMessageListenerAdapter<?, ?>)) { |
| this.logger.warn("Container 'Acknowledgment' must be async ack for Mono<?> return type " + | ||
| "(or Kotlin suspend function); otherwise the container will ack the message immediately"); | ||
| } | ||
| result = mono.toFuture(); |
There was a problem hiding this comment.
This is not OK to re-assign method argument.
I don't remember SonarCube rule, but we definitely must not override them.
So, you have to introduce internal CompletableFuture<?> variable and deal with it instead.
| @@ -870,6 +899,10 @@ private boolean rawByParameterIsType(Type parameterType, Type type) { | |||
| return parameterType instanceof ParameterizedType pType && pType.getRawType().equals(type); | |||
| } | |||
|
|
|||
| public void setObservationRegistry(ObservationRegistry observationRegistry) { | |||
There was a problem hiding this comment.
The setter is in wrong place.
Has to be somewhere after ctor with the rest of setters.
And the method might deserve JavaDoc since it is public.
spring-kafka/src/test/java/org/springframework/kafka/support/micrometer/ObservationTests.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…bleFuture, Mono)
Fixes: #3528
#3528