GH-3589: Refactor toMessage
batch method and fix logging/header issues
#3590
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BatchMessagingMessageConverter#processRecord()
#3589processRecord()
.toMessage()
as follows:addRecordInfo()
: Adds information such astype
,payload
,key
, etc. from therecord
to the given lists.addToConvertedHeaders()
: Adds the converted value ofrecord.headers()
toconvertedHeaders
.KafkaHeaders.LISTENER_INFO
key fromconvertedHeaders
, and put it torawHeaders
after the loop ends.headerMapper
, log a message so that users can refer toKafkaHeaders.NATIVE_HEADERS
. As there's no need to checkboolean logged
every time in the loop, thelogged
variable has been removed, and the check for the existence ofheaderMapper
andnatives
is now performed only once after the loop ends.Note
Also, I changed the logging level from
DEBUG
toWARN
when there is no header mapper.INFO
might be better, please let me know what you think. -> Sorry, I'll keepDEBUG
because it's logged every time the listener poll.