Lower the replication factor for transactions topic on @EmbeddedKafka Test #3602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Dltmd202 Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@Dltmd202 Thank you for signing the Contributor License Agreement! |
Dltmd202
changed the title
|
@Dltmd202 There are some checkstyle errors. Can you fix that? In addition to that, could you add your name as the author to all the classes you changed? Thanks! |
Dltmd202
force-pushed
the
gh-3557
branch
2 times, most recently
from
f4b2f0a to
4fe8d90
Compare
|
@sobychacko Of course. I will reflect it right away! Thank you |
|
Thanks for the PR! It is now merged upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3557
Expected Behavior
It would be nice if the embedded broker started by @embeddedkafka (or the similar JUnit Rule) defaulted the replication factor for the transaction state topic to the number of brokers, or a min(, 3).
Current Behavior
The embedded broker starts with the default configuration of transaction.state.log.replication.factor = 3 which doesn't make sense for a single-broker cluster, which is quite common in tests:
Fix