GH-3690: Fix observation leak in the KafkaMessageListenerContainer
#3694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enerContainer` Fixes: spring-projects#3690 When `this.listener` is an instance of `RecordMessagingMessageListenerAdapter`, we rely on its logic to call `invoke()` from super class to handle observation lifecycle this or other way. However, Spring Integration's `KafkaMessageDrivenChannelAdapter` use its own `IntegrationRecordMessageListener` extension of the `RecordMessagingMessageListenerAdapter` without calling super `invoke()`. The problem apparent from Spring Cloud Stream Kafka Binder, where an observation is enabled. * Fix `KafkaMessageListenerContainer` to check for exact type of `this.listener` before making decision to close an observation here, or propagate it down to the `RecordMessagingMessageListenerAdapter`
sobychacko
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3690
When
this.listeneris an instance ofRecordMessagingMessageListenerAdapter, we rely on its logic to callinvoke()from super class to handle observation lifecycle this or other way.However, Spring Integration's
KafkaMessageDrivenChannelAdapteruse its ownIntegrationRecordMessageListenerextension of theRecordMessagingMessageListenerAdapterwithout calling superinvoke().The problem apparent from Spring Cloud Stream Kafka Binder, where an observation is enabled.
KafkaMessageListenerContainerto check for exact type ofthis.listenerbefore making decision to close an observation here, or propagate it down to theRecordMessagingMessageListenerAdapter