propagate scope in async failures #3950
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igormq
commented
Jun 7, 2025
| acknowledge(acknowledgment); | ||
| if (canAsyncRetry(request, ex) && this.asyncRetryCallback != null) { | ||
| @SuppressWarnings("unchecked") | ||
| ConsumerRecord<K, V> record = (ConsumerRecord<K, V>) request; | ||
| this.asyncRetryCallback.accept(record, (RuntimeException) ex); | ||
| } else { |
There was a problem hiding this comment.
annoying receiving this error if we can recover from that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I still can’t reproduce the issue locally (possibly due to the use of embedded Kafka, so tests are passing for both scenarios), but applying the fix in our codebase confirms that it resolves the underlying problem.
When async returns are enabled and a failure occurs, the Kafka sender loses the original consumer’s trace context. As a result, a new trace is started, causing messages that arrive in the retry or DLT topics to have a different trace ID from the original.
Can you help me understand how to test it correctly?
P.S.: I tested over the 3.3.6 branch so I could test the jar in my project.