Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add observations auto-configuration #158

Merged
merged 1 commit into from
Oct 7, 2022
Merged

Add observations auto-configuration #158

merged 1 commit into from
Oct 7, 2022

Conversation

onobc
Copy link
Collaborator

@onobc onobc commented Oct 5, 2022 •
edited
Loading

Adds auto-configuration of the observation aspects of the listener and template.

Points of interest

  • I refactored the template and listeners to use immutable constructors for some key pieces to simplify them as well as make them auto-configuration friendly (eg. the auto-config will/not pass in the observation registry when user has disabled the obeservations property).

Resolves #147

@onobc onobc force-pushed the cbono-observation-autoconfig branch from af2826b to b6d1552 Compare October 5, 2022 22:47
@onobc onobc force-pushed the cbono-observation-autoconfig branch from b6d1552 to 7e7ac48 Compare October 7, 2022 20:54
@sobychacko sobychacko merged commit 37309d1 into spring-projects:main Oct 7, 2022
@sobychacko
Copy link
Collaborator

We did an internal code review by walking through the code. Looks good @onobc. Merged upstream.

@onobc onobc deleted the cbono-observation-autoconfig branch October 30, 2022 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support observations in Spring Boot starter
2 participants
@onobc @sobychacko