Container infrastructure for Pulsar Reader #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding the basic foundations for the Pulsar Reader container. This is similar to the message listener container mechanism used in the regular consumer for managing the various lifecycles. Resovles spring-projects#341
onobc
requested changes
Feb 15, 2023
There was a problem hiding this comment.
@sobychacko looking good! I know this is a 1st pass but I went ahead and captured my thoughts and requested some changes. Once you have adjusted what you are going to adjust in this particular pr go ahead and merge so you continue making forward progress.
Thanks.
spring-pulsar/src/main/java/org/springframework/pulsar/core/DefaultPulsarReaderFactory.java
Show resolved
Hide resolved
spring-pulsar/src/main/java/org/springframework/pulsar/core/DefaultPulsarReaderFactory.java
Show resolved
Hide resolved
spring-pulsar/src/main/java/org/springframework/pulsar/event/ReaderFailedToStartEvent.java
Show resolved
Hide resolved
spring-pulsar/src/main/java/org/springframework/pulsar/event/ReaderFailedToStartEvent.java
Show resolved
Hide resolved
...-pulsar/src/main/java/org/springframework/pulsar/reader/PulsarReaderContainerProperties.java
Outdated
Show resolved
Hide resolved
...ar/src/main/java/org/springframework/pulsar/reader/DefaultPulsarReaderListenerContainer.java
Show resolved
Hide resolved
...-pulsar/src/main/java/org/springframework/pulsar/reader/PulsarReaderContainerProperties.java
Show resolved
Hide resolved
...ng-pulsar/src/main/java/org/springframework/pulsar/reader/PulsarReaderListenerContainer.java
Outdated
Show resolved
Hide resolved
...c/test/java/org/springframework/pulsar/reader/DefaultPulsarReaderListenerContainerTests.java
Show resolved
Hide resolved
...c/test/java/org/springframework/pulsar/reader/DefaultPulsarReaderListenerContainerTests.java
Outdated
Show resolved
Hide resolved
This was referenced Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the basic foundations for the Pulsar Reader container. This is similar to the message listener container mechanism used in the regular consumer for managing the various lifecycles.
Resovles #341