Remove deprecated classes moved to other packages #17330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
|
Thanks, @ronodhirSoumik. This looks great. When you squash, will you please ensure that each class that is removed is in its own commit? In this way, if one class removal causes a problem, we can easily revert it. |
jzheaux
added
in: core
4 tasks
jzheaux
added
the
type: breaks-passivity
jzheaux
changed the title
Got it. I will finalize this PR with four class-specific commits. |
ronodhirSoumik
force-pushed
the
feature/removed-deprecated-classes
branch
2 times, most recently
from
edc92c4 to
1ef5107
Compare
|
@jzheaux requesting for final review |
Issue spring-projectsgh-17309 Signed-off-by: Soumik Sarker <[email protected]>
Issue spring-projectsgh-17309 Signed-off-by: Soumik Sarker <[email protected]>
Issue spring-projectsgh-17309 Signed-off-by: Soumik Sarker <[email protected]>
Closes spring-projectsgh-17309 Signed-off-by: Soumik Sarker <[email protected]>
jzheaux
force-pushed
the
feature/removed-deprecated-classes
branch
from
1ef5107 to
b02a45a
Compare
|
Thanks, @ronodhirSoumik! I've updated the commit messages to contain the ticket they are addressing. This will merge into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #17309