Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macros for C and Java bindings. #327

Closed
wants to merge 25 commits into from
Closed

Conversation

cobward
Copy link

@cobward cobward commented Dec 14, 2022

  • Adds macros to improve the binding definitions for C and Java.
  • Also adds prepare and complete to the C and Java APIs.

@CLAassistant
Copy link

CLAassistant commented Dec 14, 2022

CLA assistant check
All committers have signed the CLA.

@@ -97,8 +98,9 @@ $(TARGET)/test/android.stamp: $(TARGET)/didkit.jar $(ANDROID_LIBS) | $(TARGET)/t

$(TARGET)/%/release/libdidkit.so: $(RUST_SRC)
PATH=$(TOOLCHAIN)/bin:"$(PATH)" \
cargo build --lib --release --target $*
$(TOOLCHAIN)/bin/llvm-strip $@
cargo ndk --target $* build --lib --release
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm not sure about this?

@sbihel sbihel force-pushed the feat/macro-prepare-secp branch from 8e00f33 to ab64cdd Compare December 15, 2022 16:03
@cobward cobward force-pushed the feat/macro-prepare-secp branch from ab64cdd to e2f927e Compare January 11, 2023 16:33
@theosirian theosirian force-pushed the feat/macro-prepare-secp branch from 07efec3 to 9c1919d Compare February 13, 2023 19:47
@theosirian theosirian force-pushed the feat/macro-prepare-secp branch from a5070f3 to 64284c2 Compare April 24, 2023 14:31
CharlesShuller and others added 5 commits May 15, 2023 11:06
Remove dependency on macros package from C-API, and the now unnecessary c_export macro from the macros crate.
Details in the diff, but depending on how you call a dart allocator it
will either treat the supplied size as a byte count or an element count,
with potential buffer overflows as a result.

Co-authored-by: Todd Showalter <[email protected]>
* Add default context loader (nil) to calls that require it in didkit swift

* Bump flutter ffi version to ^2.0.1 to allow for new versions of flutter to build
@sbihel
Copy link
Member

sbihel commented Jul 7, 2023

Merged main to use latest ssi (0.7.0). CI is failing but for the same reason as for previous commits

@sbihel
Copy link
Member

sbihel commented Jul 12, 2023

Java 1.7 not supported anymore apparently, will investigate

@sbihel
Copy link
Member

sbihel commented Oct 25, 2024

Closing as it's uncertain we'll ever merge this

@sbihel sbihel closed this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants