-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Macros for C and Java bindings. #327
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cobward
commented
Dec 14, 2022
- Adds macros to improve the binding definitions for C and Java.
- Also adds prepare and complete to the C and Java APIs.
sbihel
reviewed
Dec 14, 2022
@@ -97,8 +98,9 @@ $(TARGET)/test/android.stamp: $(TARGET)/didkit.jar $(ANDROID_LIBS) | $(TARGET)/t | |||
|
|||
$(TARGET)/%/release/libdidkit.so: $(RUST_SRC) | |||
PATH=$(TOOLCHAIN)/bin:"$(PATH)" \ | |||
cargo build --lib --release --target $* | |||
$(TOOLCHAIN)/bin/llvm-strip $@ | |||
cargo ndk --target $* build --lib --release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmmm not sure about this?
sbihel
force-pushed
the
feat/macro-prepare-secp
branch
from
December 15, 2022 16:03
8e00f33
to
ab64cdd
Compare
cobward
force-pushed
the
feat/macro-prepare-secp
branch
from
January 11, 2023 16:33
ab64cdd
to
e2f927e
Compare
theosirian
force-pushed
the
feat/macro-prepare-secp
branch
from
February 13, 2023 19:47
07efec3
to
9c1919d
Compare
…rate secp keys Signed-off-by: Tiago Nascimento <[email protected]>
Signed-off-by: Tiago Nascimento <[email protected]>
Signed-off-by: Tiago Nascimento <[email protected]>
Signed-off-by: Tiago Nascimento <[email protected]>
… so that the rest of the build can use the stable rust toolchain (#337)
…ntext map Signed-off-by: Tiago Nascimento <[email protected]>
Signed-off-by: Tiago Nascimento <[email protected]>
Signed-off-by: Tiago Nascimento <[email protected]>
theosirian
force-pushed
the
feat/macro-prepare-secp
branch
from
April 24, 2023 14:31
a5070f3
to
64284c2
Compare
Remove dependency on macros package from C-API, and the now unnecessary c_export macro from the macros crate.
Details in the diff, but depending on how you call a dart allocator it will either treat the supplied size as a byte count or an element count, with potential buffer overflows as a result. Co-authored-by: Todd Showalter <[email protected]>
* Add default context loader (nil) to calls that require it in didkit swift * Bump flutter ffi version to ^2.0.1 to allow for new versions of flutter to build
Merged main to use latest ssi (0.7.0). CI is failing but for the same reason as for previous commits |
Java 1.7 not supported anymore apparently, will investigate |
Closing as it's uncertain we'll ever merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.