Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing a typo #378

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Fixing a typo #378

merged 2 commits into from
Dec 19, 2023

Conversation

novakboskov
Copy link
Contributor

This seems to be a simple typo. http/src/config.rs has:

#[serde_as]
#[derive(Deserialize, Debug, Clone, Hash, PartialEq, Eq)]
pub struct Issuer {
    #[serde_as(as = "Option<JsonString>")]
    pub keys: Option<Vec<JWK>>,
}

@CLAassistant
Copy link

CLAassistant commented Dec 15, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@sbihel sbihel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's to document the name of the env vars. If you like you could do

# DIDKIT_HTTP_ISSUER_KEYS
# keys = '[<JWK>, <JWK>]'

@novakboskov
Copy link
Contributor Author

Agreed.

@novakboskov novakboskov requested a review from sbihel December 18, 2023 18:58
@sbihel sbihel merged commit acb2934 into spruceid:main Dec 19, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants