Implementation of MCD capability descriptor and SA-Attestation Object (SAAO) as per ISO/IEC JTC 1/SC 17/WG 4 N 4566 #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Description - Integrate `coset` crate. - Crate module `cose` where we have `Cose` trait with some basic methods and implemented by `CoseSign1` and `CoseMac0` which are wrappers over coset analogous. - Implement `SignatureAlgorithm` trait for `CoseSign1` and `CoseMac0`. # Ref https://linear.app/spruceid/issue/SKIT-448/iso-mdl-investigate-coset # Changes - Add `CoseSign1` and `CoseMac0` wrappers over coset analogous. - Add `Cose` trait with some basic methods. - Implement `SignatureAlgorithm` for `CoseSign1` and `CoseMac0`. - Add a global map to hold signature payloads as our flow returns a reference to the payload and later that is signed externally. - Serialize/deserialize `CoseSign1` and `CoseMac0`. - Change signature flow to use the coset signature. - Use `iana::Algorithm`. ## Other changes None # Reviewers, please pay special attention to… The way `CoseSign1` is used. Signature flow and global map that hold signature payload, so we can return reference. # Tested Tested locally, running all tests. Build with these targets: ``` aarch64-linux-android armv7-linux-androideabi i686-linux-android wasm32-unknown-unknown wasm32-wasi x86_64-unknown-linux-gnu i686-unknown-linux-gnu x86_64-unknown-linux-musl x86_64-pc-windows-gnu i686-pc-windows-gnu ``` # Checklist - [x] [isomdl] Integrate `CoseSign1` - [ ] [isomdl] Integrate `COSEMac0` - [ ] [isomdl] Use coset `CoseKey` - [ ] [isomdl] Test building with `macosx` targets
# Description - Integrate `coset` crate. - Crate module `cose` where we have `Cose` trait with some basic methods and implemented by `CoseSign1` and `CoseMac0` which are wrappers over coset analogous. - Implement `SignatureAlgorithm` trait for `CoseSign1` and `CoseMac0`. # Ref https://linear.app/spruceid/issue/SKIT-448/iso-mdl-investigate-coset # Changes - Add `CoseSign1` and `CoseMac0` wrappers over coset analogous. - Add `Cose` trait with some basic methods. - Implement `SignatureAlgorithm` for `CoseSign1` and `CoseMac0`. - Add a global map to hold signature payloads as our flow returns a reference to the payload and later that is signed externally. - Serialize/deserialize `CoseSign1` and `CoseMac0`. - Change signature flow to use the coset signature. - Use `iana::Algorithm`. ## Other changes None # Reviewers, please pay special attention to… The way `CoseSign1` is used. Signature flow and global map that hold signature payload, so we can return reference. # Tested Tested locally, running all tests. Build with these targets: ``` aarch64-linux-android armv7-linux-androideabi i686-linux-android wasm32-unknown-unknown wasm32-wasi x86_64-unknown-linux-gnu i686-unknown-linux-gnu x86_64-unknown-linux-musl x86_64-pc-windows-gnu i686-pc-windows-gnu ``` # Checklist - [x] [isomdl] Integrate `CoseSign1` - [ ] [isomdl] Integrate `COSEMac0` - [ ] [isomdl] Use coset `CoseKey` - [ ] [isomdl] Test building with `macosx` targets
# Description Remove some unneeded implementations, refactor some code and other small changes. # Ref https://linear.app/spruceid/issue/SKIT-448/iso-mdl-investigate-coset # Changes - Remove `cbc-mac`. - Remove `HMAC_384_384` and `HMAC_512_512`. - Use `set_signature`. - Have `X5Chain` return `ciborium Value`. # Tested Tested locally, running all tests and build on several platforms. # Checklist - [x] [isomdl] Integrate `CoseSign1` - [ ] [isomdl] Integrate `COSEMac0` - [ ] [isomdl] Use coset `CoseKey` - [x] [isomdl] Test building with `macosx` targets
…iborium. - Add concept of CoseSign1Builder and CoseMac0Builder - Add signature prepare and verify methods - Add tests.
Co-authored-by: Jacob <[email protected]>
Co-authored-by: Jacob <[email protected]>
This reverts commit 83280a7.
This reverts commit 5cffb26.
This reverts commit a9fdf0f.
This reverts commit a73e3e4.
This reverts commit f3981ae.
… (SAAO) as per ISO/IEC JTC 1/SC 17/WG 4 N 4566.
radumarias
changed the title
# Conflicts: # .gitignore # src/definitions/traits/to_cbor.rs # src/lib.rs
…s already present when creating `PreparedCose*` objects.
…nd-saao-formats # Conflicts: # .gitignore # src/definitions/traits/to_cbor.rs # src/lib.rs
…port-to-read-the-mcd-and-saao-formats # Conflicts: # src/cose/mac0.rs # src/lib.rs
|
Closing this as we opened #97 because of some merge issues from some old code from coset integration |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add module
issuance::mcdwith the structures for MCD capability descriptor and SA-Attestation Object (SAAO).