wip: 18013-7 MDL Presentation Updates #98
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ryanmtate
changed the title
Ryanmtate
commented
Nov 20, 2024
src/presentation/reader.rs
Outdated
Comment on lines
193
to
188
| reader_key: &str, | ||
| reader_signer: impl FnOnce(Vec<u8>) -> Pin<Box<dyn Future<Output = Result<Vec<u8>>> + Send>>, |
There was a problem hiding this comment.
NOTE: Ephemeral keys are created within the session manager, and there is no need for an external signer for the DH key exchange, outside of the session manager's control.
Revert changes of the reader_signer -> reader_key
Signed-off-by: Ryan Tate <[email protected]>
Ryanmtate
force-pushed
the
skit-475-implement-isoiec-18013-7-presentation-profile-in-oid4vp-rs
branch
from
5a606b5 to
93ceba1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.