Skip to content
This repository has been archived by the owner on Sep 9, 2024. It is now read-only.

[WIP] implement basic rate limiting #80

Closed
wants to merge 1 commit into from

Conversation

fairingrey
Copy link
Contributor

Addresses #31

This uses rocket-governor to implement rate limiting.

@sbihel
Copy link
Member

sbihel commented Jan 20, 2022

I fail to see the benefits of doing rate limiting in the app, instead of at the load-balancer/proxy level. Do you think it would be beneficial to have both?

@fairingrey
Copy link
Contributor Author

@sbihel I agree more or less (that rate limiting could simply be achieved by putting a load balancer or etc in front) -- this is definitely something up for discussion. The way it's filed @wyc did seem to want rate limiting as an option in the rocket app itself.

If we decide this is not needed I can close this PR, but it doesn't seem difficult to add if needed.

@sbihel
Copy link
Member

sbihel commented Mar 10, 2022

Will close this but keep it in mind as an option. Will rephrase the issue.

@sbihel sbihel closed this Mar 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants