Camv 527 port key manager to sprucekit sdk kotlin #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CharlesShuller
approved these changes
Jun 6, 2024
| * @property input byte array to be processed. | ||
| * @return byte array with 32 bytes. | ||
| */ | ||
| fun clampOrFill(input: ByteArray): ByteArray { |
There was a problem hiding this comment.
I'm not fond of the "ByteArray! is deprecated" warnings I see, can we change to whatever the new non-deprecated type is?
There was a problem hiding this comment.
Talked about this as a team and this should be ok.
todd-spruceid
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the KeyManager for generating secret keys in the Keystore using Strongbox or TEE as a backup.