-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MDoc Reader support #22
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Ryanmtate
force-pushed
the
skit-232-iso-mdl-reader-interface-in-swift
branch
from
August 29, 2024 17:35
5f34843
to
b94d87f
Compare
Signed-off-by: Ryan Tate <[email protected]>
Signed-off-by: Ryan Tate <[email protected]>
Signed-off-by: Ryan Tate <[email protected]>
Signed-off-by: Ryan Tate <[email protected]>
Signed-off-by: Ryan Tate <[email protected]>
Ryanmtate
force-pushed
the
skit-232-iso-mdl-reader-interface-in-swift
branch
from
August 29, 2024 23:40
78b04ea
to
bb6a966
Compare
Not sure how it was checked out as it is in .gitignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested against wallet-sdk-kt.
To do:
InvalidIssuerAuthentication
, which I believe is due to it being expired -- but it does raise the question of how transparent should the Rust layer be about verification errors (opaque but simple vs transparent but complex)CBUUIDClientCharacteristicConfigurationString
needs to be set, it looks like it's set by defaultit uses write with responses instead of without (Use Write Without Response for MDoc BLE presentment mobile-sdk-kt#16)(it doesn't hurt to support writes with response, and some wallets might prefer it even if off-spec)it gets in a bad state when L2CAP characteristic is present (MDoc BLE holder gets in a bad state when L2CAP characteristic is advertised mobile-sdk-kt#17)(we shouldn't expose L2CAP characteristics as we do not yet have support for it)it's lacking a cancel button when presenting the qr code (Add cancel button during MDoc presentment mobile-sdk-kt#18)(not a blocker)Depends on: