Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Base Card, PDF417 and MRZ Scanners #29

Merged
merged 12 commits into from
Aug 27, 2024
Merged

Base Card, PDF417 and MRZ Scanners #29

merged 12 commits into from
Aug 27, 2024

Conversation

Juliano1612
Copy link
Member

@Juliano1612 Juliano1612 commented Aug 23, 2024 •
edited
Loading

This PR has the following:

  • generic multi-credential base card (+ credential pack)
  • a generic PDF417 scanner
  • an initial MRZ (OCR) scanner based on the first QR Code scanner implementation
  • refactors the previous QR Code Scanner version

@Juliano1612 Juliano1612 requested a review from w4ll3 August 23, 2024 17:34
@Juliano1612 Juliano1612 requested a review from w4ll3 August 27, 2024 13:16
w4ll3
w4ll3 approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@w4ll3 w4ll3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Juliano1612 Juliano1612 merged commit 80e798d into main Aug 27, 2024
1 check passed
@Juliano1612 Juliano1612 deleted the feat/add-generic-multicredential-card branch August 27, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@w4ll3 w4ll3 w4ll3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Juliano1612 @w4ll3