Address PR comments

src/core/authorization_request/mod.rs

@@ -17,7 +17,7 @@ use self::{
 
 use super::{
     object::{ParsingErrorContext, UntypedObject},
-    util::{base_request, HttpClient},
+    util::{base_request, AsyncHttpClient},
 };
 
 pub mod parameters;
@@ -204,7 +204,7 @@ impl AuthorizationRequestObject {
         &self.2
     }
 
-    pub async fn resolve_presentation_definition<H: HttpClient>(
+    pub async fn resolve_presentation_definition<H: AsyncHttpClient>(
         &self,
         http_client: &H,
     ) -> Result<PresentationDefinition> {

src/core/authorization_request/parameters.rs

@@ -2,7 +2,7 @@ use std::fmt;
 
 use crate::core::{
     object::{ParsingErrorContext, TypedParameter, UntypedObject},
-    util::{base_request, HttpClient},
+    util::{base_request, AsyncHttpClient},
 };
 use anyhow::{bail, Context, Error, Ok};
 use serde::{Deserialize, Serialize};
@@ -130,7 +130,7 @@ impl ClientMetadata {
     ///
     /// If the client metadata is not passed by reference or value if the Authorization Request Object,
     /// then this function will return an error.
-    pub async fn resolve<H: HttpClient>(
+    pub async fn resolve<H: AsyncHttpClient>(
         request: &AuthorizationRequestObject,
         http_client: &H,
     ) -> Result<Self, Error> {

src/core/util/mod.rs

@@ -8,7 +8,7 @@ use http::{Request, Response};
 ///
 /// A trait is used here so to facilitate native HTTP/TLS when compiled for mobile applications.
 #[async_trait]
-pub trait HttpClient {
+pub trait AsyncHttpClient {
     async fn execute(&self, request: Request<Vec<u8>>) -> Result<Response<Vec<u8>>>;
 }
 
@@ -32,7 +32,7 @@ impl ReqwestClient {
 
 #[cfg(feature = "reqwest")]
 #[async_trait]
-impl HttpClient for ReqwestClient {
+impl AsyncHttpClient for ReqwestClient {
     async fn execute(&self, request: Request<Vec<u8>>) -> Result<Response<Vec<u8>>> {
         let response = self
             .0

src/wallet.rs

@@ -11,12 +11,12 @@ use crate::core::{
     },
     metadata::WalletMetadata,
     response::{AuthorizationResponse, PostRedirection},
-    util::{base_request, HttpClient},
+    util::{base_request, AsyncHttpClient},
 };
 
 #[async_trait]
 pub trait Wallet: RequestVerifier + Sync {
-    type HttpClient: HttpClient + Send + Sync;
+    type HttpClient: AsyncHttpClient + Send + Sync;
 
     fn metadata(&self) -> &WalletMetadata;
     fn http_client(&self) -> &Self::HttpClient;

tests/jwt_vc.rs

@@ -12,7 +12,7 @@ use oid4vp::{
         },
         metadata::WalletMetadata,
         response::AuthorizationResponse,
-        util::HttpClient,
+        util::AsyncHttpClient,
     },
     verifier::{
         request_signer::P256Signer,
@@ -137,7 +137,7 @@ impl RequestVerifier for JwtVcWallet {
 }
 
 #[async_trait]
-impl HttpClient for MockHttpClient {
+impl AsyncHttpClient for MockHttpClient {
     async fn execute(&self, request: Request<Vec<u8>>) -> Result<Response<Vec<u8>>> {
         // Only expect submission.
         let body = request.body();