Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/credential improvements #14

Closed
wants to merge 76 commits into from
Closed

Feat/credential improvements #14

wants to merge 76 commits into from

Conversation

Ryanmtate
Copy link
Contributor

Re base after #8 merged.

Ryanmtate and others added 30 commits August 8, 2024 13:41
@Ryanmtate
wip: use ssi 0.8.1, debugging e2e test using did resolver
10611a8 
Signed-off-by: Ryan Tate <[email protected]>
@Ryanmtate
wip: use VerificationMethodDIDResolver for DIDClient constructor
7ea4c50 
Signed-off-by: Ryan Tate <[email protected]>
@Ryanmtate
remove unused imports
7b3ced0 
Signed-off-by: Ryan Tate <[email protected]>
@Ryanmtate
wip: debugging did resolver jwk not found in e2e flow
4a77347 
Signed-off-by: Ryan Tate <[email protected]>
@Ryanmtate
feat/improve-presentation-exchange-support-in-oid4vp-rs
48e152e 
add implementation methods for Presentation Definition.

WIP: Need to continue work for Presentation Submission and the rest
of the structs used in the presentation exchange flow.

Signed-off-by: Ryan Tate <[email protected]>

Co-authored-by: Todd Showalter <[email protected]>
@Ryanmtate
add getter methods for presentation definition member fields
26e62f1 
Signed-off-by: Ryan Tate <[email protected]>
@Ryanmtate
fix broken links in documentation
8c47808 
Signed-off-by: Ryan Tate <[email protected]>
@Ryanmtate
update presentation submission implementation
de5db7d 
Signed-off-by: Ryan Tate <[email protected]>
@Ryanmtate
fix test cases. todo: update test cases to use newly created interfac…
24845c7 
…e for presentation exchange

Signed-off-by: Ryan Tate <[email protected]>
@Ryanmtate
update json schema validator to use anyhow result type
5036a69 
Signed-off-by: Ryan Tate <[email protected]>
@Ryanmtate
merge presentation exchange updates
ac8e904 
Signed-off-by: Ryan Tate <[email protected]>
@Ryanmtate
wip: use latest implementation changes, update tests
6fe4d46 
Signed-off-by: Ryan Tate <[email protected]>
@Ryanmtate
fix verification method did resolver tests
6d29442 
Signed-off-by: Ryan Tate <[email protected]>
@Ryanmtate
wip: remove unused imports
e885a4c 
Signed-off-by: Ryan Tate <[email protected]>
@Ryanmtate
add ClaimFormat type
3996946 
Signed-off-by: Ryan Tate <[email protected]>
@Ryanmtate
add regex support for string pattern matching
4e841cc 
Signed-off-by: Ryan Tate <[email protected]>
@Ryanmtate
revert uuid presentation definition id type to string
edcc8a2 
Signed-off-by: Ryan Tate <[email protected]>
@Ryanmtate
fix: ensure negation of regex pattern match for error
23e589a 
Signed-off-by: Ryan Tate <[email protected]>
@Ryanmtate
add 'other' variante to claim format type
1527933 
Signed-off-by: Ryan Tate <[email protected]>
@Ryanmtate
remove commented out code
8ed8828 
Signed-off-by: Ryan Tate <[email protected]>
@Ryanmtate
merge presentation exchange updates
97b3462 
Signed-off-by: Ryan Tate <[email protected]>
@Ryanmtate
use ssi sub-crates instead of main ssi dependency
dcdde5c 
Signed-off-by: Ryan Tate <[email protected]>
@Ryanmtate
add jwt_vc_json and jwt_vp_json claim formats
1a2af67 
Signed-off-by: Ryan Tate <[email protected]>
@Ryanmtate
wip: construct verifiable presentation for e2e test
61043a9 
Signed-off-by: Ryan Tate <[email protected]>
@Ryanmtate
wip: perform validation on presentation submission
24497dd 
Signed-off-by: Ryan Tate <[email protected]>
@Ryanmtate
ensure range exclusive values are checked; fix inclusive range values
3423d13 
Signed-off-by: Ryan Tate <[email protected]>
@Ryanmtate
ensure enum values are parsed in alpha descending order
7bd0660 
This is a fix for a bug where ClaimFormat::JwtVc was being parsed
when ClaimFormat::JwtVp should have been instead. The fix is to
order the enum fields in alphabetical descending order, such that
VP comes BEFORE VC, and so on, for the other formats.

Signed-off-by: Ryan Tate <[email protected]>
@Ryanmtate
wip: verify authorized response presentation submission
ce60c03 
Signed-off-by: Ryan Tate <[email protected]>
@Ryanmtate
ensure json schema validator adheres to the specification
cd22624 
Signed-off-by: Ryan Tate <[email protected]>
@Ryanmtate
ensure json schema validator adheres to the specification
26dda42 
Signed-off-by: Ryan Tate <[email protected]>
Ryanmtate and others added 27 commits August 20, 2024 08:02
@Ryanmtate
use top level json path for jwt_vp_json
9997486 
Signed-off-by: Ryan Tate <[email protected]>
@Ryanmtate @cobward
Update src/verifier/client.rs
2a93750 
Co-authored-by: Jacob <[email protected]>
@Ryanmtate
rebase
f490b8b 
Signed-off-by: Ryan Tate <[email protected]>
@Ryanmtate
revert validation function async signature to use boxed pin future
347259d 
Signed-off-by: Ryan Tate <[email protected]>
@Ryanmtate
add helper methods
05d550e 
Signed-off-by: Ryan Tate <[email protected]>
@Ryanmtate
debug: jwt claim signing does not include public key
129d22c 
Signed-off-by: Ryan Tate <[email protected]>
@Ryanmtate
make request signer methods return a result
a3bf215 
Signed-off-by: Ryan Tate <[email protected]>
@Ryanmtate
refactor presentation exchange file into smaller modules
7733f65 
Signed-off-by: Ryan Tate <[email protected]>
@Ryanmtate
fix clippy warnings
54c0f79 
Signed-off-by: Ryan Tate <[email protected]>
@Ryanmtate
Merge branch 'main' into fix/fix-the-presentation-submission-in-the-o…
efd5773 
…id4vp-rs-e2e-test
@Ryanmtate
fix outcome error cause
a7aed11 
Signed-off-by: Ryan Tate <[email protected]>
@Ryanmtate
add credential format and add requested fields helper method to input…
2e453ca 
… descriptor

Signed-off-by: Ryan Tate <[email protected]>
@Ryanmtate @cobward
Update src/core/presentation_definition.rs
a3bfdcb 
Co-authored-by: Jacob <[email protected]>
@Ryanmtate @cobward
Update src/core/presentation_definition.rs
7a337ae 
Co-authored-by: Jacob <[email protected]>
@Ryanmtate
wip: add notes on required fields parsing
76e3a3a 
Signed-off-by: Ryan Tate <[email protected]>
@Ryanmtate
update vp token base64 encoding and check for multiple vp payloads
51e11e8 
Signed-off-by: Ryan Tate <[email protected]>
@Ryanmtate
move validation to auth response impl instead of presentation definit…
65e1b11 
…ion impl

Signed-off-by: Ryan Tate <[email protected]>
@Ryanmtate
remove feature gated non-optional deps
d0c7439 
Signed-off-by: Ryan Tate <[email protected]>
@Ryanmtate
remove cfg features
033fd5e 
Signed-off-by: Ryan Tate <[email protected]>
@Ryanmtate
wip: handle groups in presentation definition, input descriptor tests
d98d2a4 
Signed-off-by: Ryan Tate <[email protected]>
@Ryanmtate
remove cfg feature tags
915b922 
Signed-off-by: Ryan Tate <[email protected]>
@Ryanmtate
remove extraneous metadata helper methods; use UntypedObject for dere…
3d7b1f5 
…ferencing

Signed-off-by: Ryan Tate <[email protected]>
@Ryanmtate
add submission requirement check for presentation validation
e9b33df 
Signed-off-by: Ryan Tate <[email protected]>
@Ryanmtate
add validate method to vp token; ensure submission requirement all ru…
64f87eb 
…le is enforced.

Signed-off-by: Ryan Tate <[email protected]>
@Ryanmtate
add vp token validate unencoded method. fix minor todos.
d3dce7f 
Signed-off-by: Ryan Tate <[email protected]>
@Ryanmtate
add fmt display for credential type
c990a01 
Signed-off-by: Ryan Tate <[email protected]>
@Ryanmtate
add fmt display on credential type reference
cc17656 
Signed-off-by: Ryan Tate <[email protected]>
@Ryanmtate Ryanmtate mentioned this pull request Aug 30, 2024
Closed
@Ryanmtate
fix clippy errors
37531bb 
Signed-off-by: Ryan Tate <[email protected]>
@Ryanmtate Ryanmtate closed this Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Ryanmtate