Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor in core. #3

Closed
wants to merge 24 commits into from
Closed

Refactor in core. #3

wants to merge 24 commits into from

Conversation

cobward
Copy link
Collaborator

@cobward cobward commented Oct 9, 2023

No description provided.

Cargo.toml Outdated Show resolved Hide resolved
@sbihel
Copy link
Member

sbihel commented Oct 12, 2023

Could you take this opportunity to rename the crate to oid4vp as well?

- rename crate
- make http client to be configurable
- refactor traits and request builder
- add client metadata resolution
@sbihel sbihel mentioned this pull request Oct 31, 2023
3 tasks
));
}

bail!("")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#4

@sbihel sbihel mentioned this pull request Nov 27, 2023
@justAnIdentity
Copy link
Contributor

@cobward this looks great. Finally had a look at it 🙈

I'm planning an update and refactor of isomdl-18013-7.
There will probably be some todo's on here that spill out from that update.
Do you want to merge this and have new issues created to take care of those, or would you rather include them in this refactor in one go?

@cobward cobward changed the base branch from feat/oidc4vp-ID2 to main July 31, 2024 09:45
@cobward cobward closed this Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants